apilloud commented on code in PR #24928:
URL: https://github.com/apache/beam/pull/24928#discussion_r1063870868
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -486,6 +486,7 @@ class BeamModulePlugin implements Plugin<Project> {
def jsr305_version = "3.0.2"
def everit_json_version = "1.14.1"
def kafka_version = "2.4.1"
+ def log4j2_version = "2.19.0"
Review Comment:
Is there additional risk added by bumping the version? It was 2.17.1 before,
not sure if this small version bump will be a problem. I think 2.17.1ish is in
the Dataflow legacy worker container, will this conflict with that?
##########
sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/build.gradle:
##########
@@ -28,15 +28,6 @@ ext.summary = "Common test classes for ElasticsearchIO"
def log4j_version = "2.17.1"
Review Comment:
nit: remove this?
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -573,6 +574,7 @@ class BeamModulePlugin implements Plugin<Project> {
commons_csv :
"org.apache.commons:commons-csv:1.8",
commons_io :
"commons-io:commons-io:2.7",
commons_lang3 :
"org.apache.commons:commons-lang3:3.9",
+ commons_logging :
"commons-logging:commons-logging:1.2",
Review Comment:
We explicitly remove commons_logging in flink with comments about
jcl_over_slf4j. Do we need both?
https://github.com/apache/beam/blob/7d5d62e1ebf09eca0280bd7eea754a2223d0a416/runners/flink/job-server/flink_job_server.gradle#L75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
