nivaldoh commented on issue #21089: URL: https://github.com/apache/beam/issues/21089#issuecomment-1374500115
@TommyCpp Besides some of the smaller TODOs spread out around the codebase, adding new coders such as DoubleCoder (mirroring from the Typescript SDK) could be a great way option since their structure is a bit more organized at the moment and they can be reliably tested in isolation. However, considering the current discussions, the Dataflow is going to implement a lot of things over the weekend and likely introduce different approaches, so it might be better to wait until then. @brucearctor I agree with all your points. Additionally, @robertwb and @kennknowles need no introduction for me, so I've already sent both of them invites for collaborator access on my repo. What I really intend is to grant them owner permissions but I'm not completely familiar with this sort of thing on GitHub, so please let me know if any access is still missing after this (as well as anyone else who might require access). I'm quite happy that we might be able to use what I've done so far as the base repo for the initial stages of the Rust SDK, but if it turns out to be a better idea to move the code there into https://github.com/kennknowles/beam/tree/rust/sdks/rust instead as @brucearctor mentioned, I'd be more than happy to make any adaptations necessary so that we may continue from there. I'll also keep an eye on the progress there over the weekend to see if there's anything that could be changed in advance inside my repo. There are plenty of minor (such as the current module structure forcing me to import certain libraries in more than one Cargo file) and not so minor (such as downcasting coders from Any and using their literal TypeId as a key) things that need to be restructured soon over here, so I'll be looking for ideas to improve them and speed up the merge as well. On a random bonus note, my work vacation starts soon, so progress should start moving a lot faster and I'll also be able to dedicate more time here for further collaboration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
