mosche commented on code in PR #24837:
URL: https://github.com/apache/beam/pull/24837#discussion_r1067028679


##########
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/MultiDoFnFunction.java:
##########
@@ -180,14 +186,14 @@ public TimerInternals timerInternals() {
     DoFnRunnerWithMetrics<InputT, OutputT> doFnRunnerWithMetrics =
         new DoFnRunnerWithMetrics<>(stepName, doFnRunner, metricsAccum);
 
-    return new SparkProcessContext<>(
+    SparkProcessContext<Object, InputT, OutputT> ctx =
+        new SparkProcessContext<>(

Review Comment:
   @JozoVilcek Please feel free to discard or ignore! [This code 
here](https://github.com/JozoVilcek/beam/commit/e055041b73331cd2d1c3161033906f49b9c361e8)
 is quickly hacked together and just meant to demonstrate what I had in mind 
above. `SparkInputDataProcessor` was replaced by `SparkOutputManager`, no 
`SparkProcessContext` and output iterator needed anymore. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to