damondouglas commented on code in PR #24457: URL: https://github.com/apache/beam/pull/24457#discussion_r1067546972
########## playground/frontend/playground_components/lib/src/controllers/public_notifier.dart: ########## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import 'package:flutter/material.dart'; + +class PublicNotifier extends ChangeNotifier { Review Comment: Is this class compensating where the get_it package failed? I'm not familiar with the get_it package and normally able to achieve state management via the InheritedNotiferProvider. ########## learning/tour-of-beam/frontend/test/main_test.dart: ########## @@ -0,0 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +void main() { + // TODO(nausharipov): add unit and integration tests Review Comment: Could we add and reference a GitHub Issue in this TODO? ########## learning/tour-of-beam/frontend/README.md: ########## @@ -17,47 +17,67 @@ under the License. --> - # Tour of Beam - These are the main sources of the Tour of Beam website. +# Tour of Beam - # About +These are the main sources of the Tour of Beam website. + +# About ## Getting started -Running, debugging, and testing all require this first step that fetches -dependencies and generates code: + +This project relies on generated code for some functionality: +deserializers, test mocks, constants for asset files, +extracted Beam symbols for the editor, etc. + +All generated files are version-controlled, so after checkout the project is immediately runnable. +However, after changes you may need to re-run code generation: ```bash -cd ../../../playground/frontend/playground_components -flutter pub get -flutter pub run build_runner build -cd ../../../learning/tour-of-beam/frontend -flutter pub get +cd beam +./gradlew :playground:frontend:playground_components:generateCode +cd learning/tour-of-beam/frontend flutter pub run build_runner build Review Comment: Additionally, why is there a need for `flutter pub run build_runner build` when we see files such as `learning/tour-of-beam/frontend/lib/auth/method.g.dart`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
