Abacn commented on code in PR #24964:
URL: https://github.com/apache/beam/pull/24964#discussion_r1067646215
##########
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOIT.java:
##########
@@ -212,14 +210,16 @@ public void
testKafkaIOReadsAndWritesCorrectlyInStreaming() throws IOException {
PipelineResult writeResult = writePipeline.run();
PipelineResult.State writeState = writeResult.waitUntilFinish();
+ // Fail the test if pipeline failed.
+ assertNotEquals(PipelineResult.State.FAILED, writeState);
Review Comment:
Current failing on master is due to the write pipeline continuously hitting
OOM and cannot finish the bundle within timeout; then read pipeline does not
receive expected number of data, e.g.
https://ci-beam.apache.org/view/PerformanceTests/job/beam_PerformanceTests_Kafka_IO/3546/console
```
org.apache.beam.sdk.io.kafka.KafkaIOIT >
testKafkaIOReadsAndWritesCorrectlyInStreaming FAILED
20:26:04 java.lang.AssertionError: actual number of records 34569527
smaller than expected: 100000000.
```
put this assertion right after writeResult.waitUntilFinish() to make test
fail early if write pipeline fails.
The OOM issue is also a motivation of using single Callback instance (though
not have decisive help)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
