nausharipov commented on code in PR #24457:
URL: https://github.com/apache/beam/pull/24457#discussion_r1067850755
##########
learning/tour-of-beam/frontend/lib/cache/content_tree.dart:
##########
@@ -18,21 +18,17 @@
import 'dart:async';
-import 'package:flutter/widgets.dart';
-
import '../models/content_tree.dart';
-import '../repositories/client/client.dart';
+import 'cache.dart';
-class ContentTreeCache extends ChangeNotifier {
- final TobClient client;
+class ContentTreeCache extends Cache {
Review Comment:
I've added a comment to the `Cache` class.
##########
learning/tour-of-beam/frontend/lib/cache/content_tree.dart:
##########
@@ -18,21 +18,17 @@
import 'dart:async';
-import 'package:flutter/widgets.dart';
-
import '../models/content_tree.dart';
-import '../repositories/client/client.dart';
+import 'cache.dart';
-class ContentTreeCache extends ChangeNotifier {
- final TobClient client;
+class ContentTreeCache extends Cache {
+ ContentTreeCache({
+ required super.client,
+ });
final _treesBySdkId = <String, ContentTreeModel>{};
final _futuresBySdkId = <String, Future<ContentTreeModel>>{};
- ContentTreeCache({
- required this.client,
- });
-
ContentTreeModel? getContentTree(String sdkId) {
final future = _futuresBySdkId[sdkId];
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
