yirutang commented on code in PR #24145:
URL: https://github.com/apache/beam/pull/24145#discussion_r1068394790
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java:
##########
@@ -652,6 +692,18 @@ public void process(
}
appendSplitDistribution.update(numAppends);
+ if (updatedSchemaReturned.get() != null) {
Review Comment:
Yes, the logic can be simplified down to:
https://screenshot.googleplex.com/9o5fvs3UgNEWa9E
No extra comparison needed.
However it can only capture the first schema update event, which is enough
since we will refresh the whole writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
