AnandInguva commented on code in PR #24948:
URL: https://github.com/apache/beam/pull/24948#discussion_r1070000902
##########
sdks/python/apache_beam/options/pipeline_options_test.py:
##########
@@ -310,6 +310,19 @@ def test_from_dictionary(self):
options.view_as(PipelineOptionsTest.MockOptions).mock_json_option,
case['expected'].get('mock_json_option', {}))
+ def test_none_from_dictionary(self):
+ class NoneDefaultOptions(PipelineOptions):
+ @classmethod
+ def _add_argparse_args(cls, parser):
+ parser.add_argument('--test_arg_none', default=None, type=int)
+ parser.add_argument('--test_arg_int', default=1, type=int)
+
+ options_dict = {'test_arg_none': None, 'test_arg_int' : 5}
Review Comment:
```suggestion
options_dict = {'test_arg_none': None, 'test_arg_int': 5}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
