Abacn commented on PR #24998: URL: https://github.com/apache/beam/pull/24998#issuecomment-1385807113
I tend to think there was some reason retry did not apply there otherwise it is just a trivial annotation so why add a TODO there. This is a pretty low level code, the implementation of writing gcs file with same interface of a python file handle (open(s, 'w') as f; f.write(...)) The reason why there wasn't get retried is that the current implementation is not idempotent. A retry can cause a corrupted file. So currently it fails the bundle and make the whole file rewritten to gcs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
