alnzng commented on code in PR #25031:
URL: https://github.com/apache/beam/pull/25031#discussion_r1072645256


##########
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaPortablePipelineOptions.java:
##########
@@ -29,4 +30,11 @@
   String getFsTokenPath();
 
   void setFsTokenPath(String path);
+
+  @Description(
+      "Wait if necessary for completing a remote bundle processing for at most 
the given time (in milliseconds). if the value of timeout is negative, wait 
forever until the bundle processing is completed. Used only in portable mode.")
+  @Default.Long(-1)
+  long getBundleProcessingTimeout();
+
+  void setBundleProcessingTimeout(long timeoutMs);

Review Comment:
   Good suggestion. I think we can move this config to `SamzaPipelineOptions` 
and call out that this config is supported in portable mode only for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to