Abacn commented on code in PR #24851:
URL: https://github.com/apache/beam/pull/24851#discussion_r1073862470
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -174,6 +174,12 @@ protected JdbcIO.DataSourceConfiguration
getDataSourceConfiguration() {
.collect(Collectors.toList());
dataSourceConfiguration =
dataSourceConfiguration.withConnectionInitSqls(initSqls);
}
+
+ @Nullable Integer maxConnections = config.getInt32("maxConnections");
Review Comment:
we should tolerate the incoming schema not containing this field for
backward compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
