damccorm opened a new pull request, #25106:
URL: https://github.com/apache/beam/pull/25106
Right now, running the following pipeline on Dataflow:
```
import logging
import apache_beam as beam
from apache_beam.options.pipeline_options import DebugOptions
def merge(vals):
out = ""
for v in vals:
out += v
return out
def run():
pipeline_options = DebugOptions()
pipeline_options.dataflow_job_file = "path/to/dump/proto"
with beam.Pipeline(options=pipeline_options) as p:
(p
| beam.Create([("key1", "foo"), ("key2", "bar"), ("key1",
"baz")])
| beam.GroupByKey()
| beam.CombineValues(merge)
)
if __name__ == '__main__':
logging.getLogger().setLevel(logging.INFO)
run()
```
succeeds when `use_runner_v2` is not included as an experiment, but fails
when it is. This is because the translation being done generates an invalid
graph for the `use_runner_v2` case: a portable pipeline shouldn't be using the
overridden combine here.
This fixes the problem by moving the override to only occur when
`use_runner_v2` is not included
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
