ZijieSong946 commented on a change in pull request #12174:
URL: https://github.com/apache/beam/pull/12174#discussion_r454554801
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##########
@@ -808,9 +808,11 @@ private RexNode convertSimpleValueToRexNode(TypeKind kind,
Value value) {
value.getStringValue(),
typeFactory().createSqlType(SqlTypeName.VARCHAR), true);
break;
case TYPE_NUMERIC:
- // As ZetaSQL NUMERIC literal would be unparsed as DOUBLE through
Calcite makeExactLiteral
- // method, we design a function call specifically associate with
ZetaSQL NUMERIC literal
- // unparsing
+ // Cannot simply call makeExactLiteral() for ZetaSQL NUMERICE type
because later it will be
Review comment:
Fixed. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
