y1chi commented on code in PR #25104:
URL: https://github.com/apache/beam/pull/25104#discussion_r1084709503
##########
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataGrpcMultiplexer2.java:
##########
@@ -253,15 +253,13 @@ public void onError(Throwable t) {
"Failed to handle for {}",
apiServiceDescriptor == null ? "unknown endpoint" :
apiServiceDescriptor,
t);
- outboundObserver.onCompleted();
}
@Override
public void onCompleted() {
LOG.warn(
"Hanged up for {}.",
apiServiceDescriptor == null ? "unknown endpoint" :
apiServiceDescriptor);
- outboundObserver.onCompleted();
}
}
}
Review Comment:
Maybe we can rename this class to just BeamFnDataGrpcMultiplexer with a
follow up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
