damccorm commented on code in PR #25123:
URL: https://github.com/apache/beam/pull/25123#discussion_r1085448799
##########
sdks/python/tox.ini:
##########
@@ -17,6 +17,8 @@
[tox]
# new environments will be excluded by default unless explicitly added to
envlist.
+requires =
+ grpcio-tools==1.37.0
Review Comment:
Do you know why we now need this dependency?
##########
.github/workflows/python_tests.yml:
##########
@@ -116,16 +116,19 @@ jobs:
- name: Get build dependencies
working-directory: ./sdks/python
run: pip install -r build-requirements.txt
+ - name: Generate protos
+ working-directory: ./sdks/python
+ run: python gen_protos.py
Review Comment:
Why do we need this step now when we didn't before?
##########
.github/workflows/python_tests.yml:
##########
@@ -116,16 +116,19 @@ jobs:
- name: Get build dependencies
working-directory: ./sdks/python
run: pip install -r build-requirements.txt
+ - name: Generate protos
+ working-directory: ./sdks/python
+ run: python gen_protos.py
- name: Install tox
- run: pip install tox==3.27.1
+ run: pip install tox
Review Comment:
Should we still pin to a 4.x version to avoid this possibly breaking when
tox 5.x is released?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
