tvalentyn commented on code in PR #24435:
URL: https://github.com/apache/beam/pull/24435#discussion_r1085789731
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -2474,9 +2474,13 @@ def typed(transform):
# Capture in closure (avoiding capturing self).
args, kwargs = self.args, self.kwargs
+ #TODO: We need to add support for multi-window inputs to
CombineGlobally()
def inject_default(_, combined):
if combined:
- assert len(combined) == 1
+ if len(combined) > 1:
+ raise ValueError(
+ "Input from multiple simultaneous windows"
+ "isn't currently supported for CombineGlobally()")
Review Comment:
I chatted briefly with @robertwb and my understanding is that
CombineGlobally is expected support multiple windows, so this message may be
confusing to users. We'll need to look further to understand the failure mode
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
