damondouglas opened a new pull request, #25171:
URL: https://github.com/apache/beam/pull/25171

   This PR closes #25119 and addresses #19465 by:
   1. Change .test-infra/kubernetes/kafka-cluster/04-outside-services from 
LoadBalancer to NodePort
   2. Refactor 
.test-infra/kubernetes/kafka-cluster/05-kafka/10broker-config.yml to query 
`OUTSIDE_HOST` from k8s node `InternalIP` and `OUTSIDE_PORT` to query 
`outside-${KAFKA_BROKER_ID}`'s NodePort
   3. Added `nodeIPAddress` and `nodePort` methods to 
.test-infra/jenkins/Kubernetes.groovy and cooresponding 
.test-infra/kubernetes/kubernetes.sh to enable Node InternalIP and NodePort 
querying within a jenkins job context
   4. Refactor the following with `usePublicIps=false`
       - .test-infra/jenkins/job_PerformanceTests_xlang_KafkaIO_Python.groovy
       - .test-infra/jenkins/job_PerformanceTests_KafkaIO_IT.groovy
   5. terraform code to validate and provision Google Cloud networking 
requirements to support `usePublicIps=false` (Note: I already executed the 
terraform code, per personal communication, on apache-beam-testing GCP project)
   
   I was unable to test end-to-end the new workflow from jenkins job creation 
to seeing a Dataflow Job executing successfully in my own Google Cloud 
environment.  However, I was able to validate:
   1. Using a private IP compute engine instance in the same GCP network, 
https://kafka.apache.org/quickstart worked using the kubernetes cluster's node 
InternalIP and NodePort as the `--bootstrap-server`
   2. Spinning up .test-infra/dockerized-jenkins and seeding 
`job_PerformanceTests_xlang_KafkaIO_Python.groovy` from 
github.com/damondouglas/beam from branch `25119-fix-test-infra-kafka-service` 
built the test job using the queried kubernetes Node InternalIP and NodePort as 
the bootstrap_server arguments
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
    - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable. This will automatically add a link to the 
pull request in the issue. If you would like the issue to automatically close 
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - ~Update `CHANGES.md` with noteworthy changes.~
    - ~If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).~
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit 
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   
------------------------------------------------------------------------------------------------
   [![Build python source distribution and 
wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python 
tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java 
tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go 
tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more 
information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to