mosche commented on code in PR #24992:
URL: https://github.com/apache/beam/pull/24992#discussion_r1088706540
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/CountingSource.java:
##########
@@ -481,11 +489,45 @@ public long getSplitBacklogBytes() {
}
}
+ public static class CounterMarkCoder extends CustomCoder<CounterMark> {
Review Comment:
Sure, of course, but that's not the point I'm making. Switching coders is
sketchy and can cause trouble if the encoded bytes are persisted somehow.
Assuming somebody migrates a pipeline that uses checkpoints containing an
Avro encoded `CounterMark` (unlikely, but possible), switching the coder here
without being binary compatible will cause issues when migrating to the new
Beam version...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
