Abacn commented on code in PR #25209:
URL: https://github.com/apache/beam/pull/25209#discussion_r1089781681
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java:
##########
@@ -315,16 +324,19 @@ public void writeDynamicDestinations(boolean schemas,
boolean autoSharding) thro
final List<String> allUsernames = ImmutableList.of("bill", "bob",
"randolph");
List<String> userList = Lists.newArrayList();
- // Make sure that we generate enough users so that WriteBundlesToFiles is
forced to spill to
- // WriteGroupedRecordsToFiles.
- for (int i = 0; i < BatchLoads.DEFAULT_MAX_NUM_WRITERS_PER_BUNDLE * 10;
++i) {
- // Every user has 10 nicknames.
- for (int j = 0; j < 10; ++j) {
+ // i controls the number of destinations
+ for (int i = 0; i < maxNumWritersPerBundle * 2; ++i) {
Review Comment:
with these parameters the number of files has been reduced 10 times (2000 ->
200+) while target codes are tested consistently (previously there is some code
not gets covered, see above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
