lukecwik commented on code in PR #25219:
URL: https://github.com/apache/beam/pull/25219#discussion_r1091207885
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1553,7 +1553,7 @@ class BeamModulePlugin implements Plugin<Project> {
if (project.file("/opt/cprof/profiler_java_agent.so").exists()) {
def gcpProject = project.findProperty('gcpProject') ?:
'apache-beam-testing'
def userName =
System.getProperty("user.name").toLowerCase().replaceAll(" ", "_")
- jvmArgs
'-agentpath:/opt/cprof/profiler_java_agent.so=-cprof_service=' + userName + "_"
+ project.getProperty("benchmark").toLowerCase() + '_' +
System.currentTimeMillis() + ',-cprof_project_id=' + gcpProject +
',-cprof_zone_name=us-central1-a'
+ jvmArgs
'-agentpath:/opt/cprof/profiler_java_agent.so=-cprof_service=' + userName + "_"
+ project.getProperty("benchmark").toLowerCase() + '_' +
String.format('%1$tm%1$td%1$tY_%1$tH%1$tM%1$tS%1$tL',
System.currentTimeMillis()) + ',-cprof_project_id=' + gcpProject +
',-cprof_zone_name=us-central1-a'
Review Comment:
this improves the generated name to contain date and time in a human
readable format instead of millis since epoch so it is easier to compare your
benchmark runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
