alexeyinkin commented on code in PR #25033:
URL: https://github.com/apache/beam/pull/25033#discussion_r1091613660
##########
playground/frontend/integration_test/standalone_cancel_running_example_test.dart:
##########
@@ -49,15 +43,8 @@ void main() {
Future<void> _runAndCancelExample(WidgetTester wt, Duration duration) async {
await wt.tap(find.runOrCancelButton());
- try {
- await wt.pumpAndSettle(
- const Duration(milliseconds: 100),
- EnginePhase.sendSemanticsUpdate,
- duration,
- );
- } catch (e) {
- //ignore
- }
+
+ await wt.wait(duration);
Review Comment:
To me this is a lesser evil than inventing a method with a vague name
without being sure how exactly it does what it does. We can just test the
result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
