aromanenko-dev commented on PR #24992: URL: https://github.com/apache/beam/pull/24992#issuecomment-1410720243
@mosche Thanks, review comments are addressed. > Though, still flagging the coder replacement of CountingSource as potential issue. I can't think of use cases where one would checkpoint this, but who knows .. We can keep it "as it is" for now but it will be anyway a breaking change once Avro will be dropped from "core". Do you see any other options? > Do you want to move ahead and merge or get more people to ack? Thanks for review! Before merging, if possible, I'd be happy to have another look on this PR to make sure that we didn't miss something. Ping @kennknowles @reuvenlax @lukecwik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
