mosche commented on code in PR #25187:
URL: https://github.com/apache/beam/pull/25187#discussion_r1093493395
##########
runners/spark/3/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/batch/PipelineTranslatorBatch.java:
##########
@@ -61,25 +61,25 @@ public class PipelineTranslatorBatch extends
PipelineTranslator {
//
https://github.com/seznam/euphoria/blob/master/euphoria-spark/src/main/java/cz/seznam/euphoria/spark/SparkFlowTranslator.java#L106
static {
- TRANSFORM_TRANSLATORS.put(Impulse.class, new ImpulseTranslatorBatch());
- TRANSFORM_TRANSLATORS.put(Combine.PerKey.class, new
CombinePerKeyTranslatorBatch<>());
- TRANSFORM_TRANSLATORS.put(Combine.Globally.class, new
CombineGloballyTranslatorBatch<>());
+ TRANSFORM_TRANSLATORS.put(Impulse.class, new ImpulseTranslatorBatch(0));
Review Comment:
That's the way i implemented it initially... I personally find it easier to
have an overview of all values in a single place, but happy to revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
