TSultanov commented on code in PR #24874:
URL: https://github.com/apache/beam/pull/24874#discussion_r1094375294
##########
playground/backend/internal/code_processing/code_processing.go:
##########
@@ -172,7 +172,11 @@ func compileStep(ctx context.Context, cacheService
cache.Cache, paths *fs_tool.L
return nil
}
} else { // in case of Java, Go (not unit test), Scala - need compile
step
- executorBuilder := builder.Compiler(paths, sdkEnv)
+ executorBuilder, err := builder.Compiler(paths, sdkEnv)
Review Comment:
There is a problem with this method that it takes two contexts, this is
something which will require careful consideration on why this was done this
way and how it can be rectified.
Also refactoring the call chain leading to this function so it will be able
to return the error also will require some thought and it goes beyond the scope
of this PR.
Filed a task to resolve this separately:
https://github.com/apache/beam/issues/25277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
