pabloem commented on code in PR #25268:
URL: https://github.com/apache/beam/pull/25268#discussion_r1094946896
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java:
##########
@@ -1121,7 +1121,8 @@ public boolean typesEqual(Field other) {
private boolean equivalent(Field otherField, EquivalenceNullablePolicy
nullablePolicy) {
return getName().equals(otherField.getName())
- && getType().equivalent(otherField.getType(), nullablePolicy);
+ && getType().equivalent(otherField.getType(), nullablePolicy)
+ && getDescription().equals(otherField.getDescription());
Review Comment:
this is checking whole Field equivalence, not just type. For Type
equivalence we have `FieldType.equivalent(..)`, and `Field.typesEqual(...)` -
thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
