kw2542 commented on code in PR #25265:
URL: https://github.com/apache/beam/pull/25265#discussion_r1095048191
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaMetricsBundleProgressHandler.java:
##########
@@ -90,7 +90,9 @@ public void
onProgress(BeamFnApi.ProcessBundleProgressResponse progress) {}
public void onCompleted(BeamFnApi.ProcessBundleResponse response) {
response.getMonitoringInfosList().stream()
.filter(monitoringInfo -> !monitoringInfo.getPayload().isEmpty())
- .forEach(this::parseAndUpdateMetric);
+ .map(this::parseAndUpdateMetric)
+ .distinct()
+ .forEach(samzaMetricsContainer::updateMetrics);
Review Comment:
why do we need to update the metrics again here? IIRC, beam native counter,
gauge and distribution metric is integrated with samza metrics already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
