udim commented on a change in pull request #12009:
URL: https://github.com/apache/beam/pull/12009#discussion_r455213683
##########
File path: website/www/site/content/en/documentation/sdks/python-type-safety.md
##########
@@ -90,6 +91,15 @@ The following code declares an `int` input and a `str`
output type hint on the `
{{< code_sample
"sdks/python/apache_beam/examples/snippets/snippets_test_py3.py"
type_hints_map_annotations >}}
{{< /highlight >}}
+The following code demonstrates how to use annotations on `PTransform`
subclasses.
+A valid annotation is a `PCollection`, `PBegin`, or `PDone` that wraps an
internal (nested) type.
Review comment:
The dev list
[discussion](https://lists.apache.org/thread.html/r5cad76ea7b5b8404d159dd14c24964242b1d4b49787d6aa6c162d948%40%3Cdev.beam.apache.org%3E)
seems to have a consensus:
- Make PBegin public (add to \_\_all\_\_ list)
- Deprecate PDone return type in favor of None. We still need to be
backwards compatible, but update this PR to support the None return type for
expand.
Additional documentation will be tracked in
https://issues.apache.org/jira/browse/BEAM-10495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
