Abacn commented on PR #25317: URL: https://github.com/apache/beam/pull/25317#issuecomment-1419548038
Thanks for contribution. Would you mind also add the tests in https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/filesystem_test.py ? e.g. https://github.com/apache/beam/blob/fd4ea9b6bcebfac1c161805fa8d741cf20cc38eb/sdks/python/apache_beam/io/filesystem_test.py#L339 and other places where compression types are enumerated Besides, the code format check failure showing following message: ``` 10:13:37 ************* Module apache_beam.io.filesystem 10:13:37 apache_beam/io/filesystem.py:276:62: C0303: Trailing whitespace (trailing-whitespace) 10:13:37 apache_beam/io/filesystem.py:968:0: C0304: Final newline missing (missing-final-newline) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
