tvalentyn commented on code in PR #25313:
URL: https://github.com/apache/beam/pull/25313#discussion_r1098263435
##########
sdks/python/apache_beam/runners/worker/bundle_processor.py:
##########
@@ -823,6 +825,38 @@ def only_element(iterable):
return element
+def _extract_py_version(capability):
+ return capability[len(_PY_SDK_CAPABILITY_PREFIX):].split("_sdk:")[0]
+
+
+def _verify_descriptor_created_in_a_compatible_env(process_bundle_descriptor):
+ # type: beam_fn_api_pb2.ProcessBundleDescriptor -> None
+
+ py_envs_at_submission = set()
+ for _, env in process_bundle_descriptor.environments.items():
Review Comment:
> There is still a list of environments in PBD.
... and it includes an "empty" environment:
(from
[logs](https://pantheon.corp.google.com/logs/query;query=resource.type%3D%22dataflow_step%22%0Aresource.labels.job_id%3D%222023-02-06_22_44_06-7899562700680057780%22%0Aref_Environment_default_environment_1%0A;timeRange=2023-02-07T06:44:06.936Z%2F2023-02-07T06:50:27.603Z;cursorTimestamp=2023-02-07T06:48:10.892833709Z?project=google.com:clouddfe))
```
environments {
key: ""
value {
}
}
environments {
key: "ref_Environment_default_environment_1"
value {
urn: "beam:env:docker:v1"
payload: "\n apache/beam_python3.9_sdk:2.44.0"
capabilities: "beam:coder:bytes:v1"
capabilities: "beam:coder:string_utf8:v1"
capabilities: "beam:coder:kv:v1"
capabilities: "beam:coder:bool:v1"
capabilities: "beam:coder:varint:v1"
capabilities: "beam:coder:double:v1"
capabilities: "beam:coder:iterable:v1"
capabilities: "beam:coder:timer:v1"
capabilities: "beam:coder:interval_window:v1"
capabilities: "beam:coder:length_prefix:v1"
capabilities: "beam:coder:global_window:v1"
capabilities: "beam:coder:windowed_value:v1"
capabilities: "beam:coder:param_windowed_value:v1"
capabilities: "beam:coder:state_backed_iterable:v1"
capabilities: "beam:coder:custom_window:v1"
capabilities: "beam:coder:row:v1"
capabilities: "beam:coder:sharded_key:v1"
capabilities: "beam:coder:nullable:v1"
capabilities: "beam:protocol:progress_reporting:v0"
capabilities: "beam:protocol:harness_monitoring_infos:v1"
capabilities: "beam:protocol:worker_status:v1"
capabilities: "beam:combinefn:packed_python:v1"
capabilities:
"beam:version:sdk_base:apache/beam_python3.8_sdk:2.46.0.dev"
capabilities: "beam:transform:sdf_truncate_sized_restrictions:v1"
capabilities: "beam:transform:to_string:v1"
capabilities: "beam:protocol:sibling_workers:v1"
dependencies {
type_urn: "beam:artifact:type:url:v1"
type_payload:
"\nlgs://clouddfe-valentyn/beamapp-valentyn-0207064357-172319-kxdzeic6.1675752237.172464/dataflow_python_sdk.tar"
role_urn: "beam:artifact:role:staging_to:v1"
role_payload: "\n\027dataflow_python_sdk.tar"
}
dependencies {
type_urn: "beam:artifact:type:url:v1"
type_payload:
"\nigs://clouddfe-valentyn/beamapp-valentyn-0207064357-172319-kxdzeic6.1675752237.172464/pickled_main_session"
role_urn: "beam:artifact:role:staging_to:v1"
role_payload: "\n\024pickled_main_session"
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
