robinyqiu commented on pull request #12247: URL: https://github.com/apache/beam/pull/12247#issuecomment-658934753
> I know of at least one customer use case where they are disabling BeamZetaSqlCalcRel so they can avoid JNI. We also have plans to turn BeamCalcRel back on for simple operators to enable better performance. That make sense. Thanks for sharing this information. But I do believe it makes our code cleaner to move those files which are only used on the BeamZetaSqlCalcRel disabled path together. So how about I move those code to a new `/impl` subdirectory, instead of deleting them? > I believe the preferred method is git pull --rebase or git rebase upstream/master. Sure, I can do that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
