lukecwik commented on PR #25354: URL: https://github.com/apache/beam/pull/25354#issuecomment-1421402599
Can you address the checkstyle failures? see https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Commit/25154/checkstyle/new/#issuesContent ``` Details | File | Package | Category | Type | Severity | Age -- | -- | -- | -- | -- | -- | -- | ProcessBundleHandler.java:23 | org.apache.beam.fn.harness.control | Imports | AvoidStarImportCheck | Error | 1 Using the '.*' form of import should be avoided - java.util.*.Since Checkstyle 3.0Checks that there are no import statements that use the * notation.Rationale: Importing all classes from a package or static members from a class leads to tight coupling between packages or classes and might lead to problems when a new version of a library introduces name clashes. | DataSamplingDescriptorModifier.java:1 | org.apache.beam.fn.harness.debug | Javadoc | JavadocPackageCheck | Error | 1 Missing package-info.java file.Since Checkstyle 5.0Checks that each Java package has a Javadoc file used for commenting. By default it only allows a package-info.java file, but can be configured to allow a package.html file.An error will be reported if both files exist as this is not allowed by the Javadoc tool. | ProcessBundleDescriptorModifier.java:40 | org.apache.beam.fn.harness | Naming | MethodNameCheck | Error | 1 Name 'ModifyProcessBundleDescriptor' must match pattern '^[a-z][a-zA-Z0-9]*(_[a-zA-Z0-9]+)*.Checks that method names conform to a format specified by the format property.Also, checks if a method name has the same name as the residing class. The default is false (it is not allowed). It is legal in Java to have method with the same name as a class. As long as a return type is specified it is a method and not a constructor which it could be easily confused as. Does not check-style the name of an overridden methods because the developer does not have a choice in renaming such methods. | DataSamplerTest.java:27 | org.apache.beam.fn.harness.debug | Imports | AvoidStarImportCheck | Error | 1 | DataSamplingDescriptorModifierTest.java:41 | org.apache.beam.fn.harness.debug | Naming | LocalFinalVariableNameCheck | Error | 1 Name 'PCOLLECTION_ID_A' must match pattern '^[a-z][a-zA-Z0-9]*.Checks that local final variable names conform to a format specified by the format property. A catch parameter and resources in try statements are considered to be a local, final variables. | DataSamplingDescriptorModifierTest.java:42 | org.apache.beam.fn.harness.debug | Naming | LocalFinalVariableNameCheck | Error | 1 | DataSamplingDescriptorModifierTest.java:43 | org.apache.beam.fn.harness.debug | Naming | LocalFinalVariableNameCheck | Error | 1 | DataSamplingDescriptorModifierTest.java:44 | org.apache.beam.fn.harness.debug | Naming | LocalFinalVariableNameCheck | Error | 1 | DataSamplingDescriptorModifierTest.java:71 | org.apache.beam.fn.harness.debug | Naming | LocalFinalVariableNameCheck | Error | 1 | DataSamplingDescriptorModifierTest.java:72 | org.apache.beam.fn.harness.debug | Naming | LocalFinalVariableNameCheck | Error | 1 | DataSamplingFnRunnerTest.java:22 | org.apache.beam.fn.harness.debug | Imports | AvoidStarImportCheck | Error | 1 | DataSamplingFnRunnerTest.java:25 | org.apache.beam.fn.harness.debug | Imports | AvoidStarImportCheck | Error | 1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
