damccorm commented on code in PR #24725:
URL: https://github.com/apache/beam/pull/24725#discussion_r1100524548
##########
sdks/python/setup.py:
##########
@@ -343,15 +345,12 @@ def get_portability_package_data():
'azure-core >=1.7.0',
'azure-identity >=1.12.0',
],
- #(TODO): Some tests using Pandas implicitly calls inspect.stack()
- # with python 3.10 leading to incorrect stacktrace.
- # This can be removed once dill is updated to version > 0.3.5.1
- # Issue: https://github.com/apache/beam/issues/23566
+ # Exclude pandas<=1.4.2 since it doesn't work with numpy 1.24.x.
# Exclude 1.5.0 and 1.5.1 because of
# https://github.com/pandas-dev/pandas/issues/45725
'dataframe': [
- 'pandas>=1.0,<1.6,!=1.5.0,!=1.5.1;python_version<"3.10"',
- 'pandas>=1.4.3,<1.6,!=1.5.0,!=1.5.1;python_version>="3.10"'
+ 'pandas<1.4.0;python_version=="3.7"',
+ 'pandas>=1.4.3,!=1.5.0,!=1.5.1,<1.6;python_version>="3.8"',
Review Comment:
Hm, this isn't even a year old (its from June 2022) so I imagine we'll be
booting some users off of older versions of Pandas. I think that's probably
worth it though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
