olehborysevych commented on code in PR #25357:
URL: https://github.com/apache/beam/pull/25357#discussion_r1101464266
##########
playground/backend/internal/emulators/emulator.go:
##########
@@ -49,49 +55,51 @@ func PrepareMockClustersAndGetPrepareParams(request
*pb.RunCodeRequest) ([]Emula
datasetsByEmulatorTypeMap[dataset.Type] = datasets
}
- var prepareParams = make(map[string]string)
var mockClusters = make([]EmulatorMockCluster, 0)
for emulatorType, datasets := range datasetsByEmulatorTypeMap {
switch emulatorType {
case pb.EmulatorType_EMULATOR_TYPE_KAFKA:
- kafkaMockCluster, err := NewKafkaMockCluster()
+ kafkaMockCluster, err :=
NewKafkaMockCluster(configuration.KafkaEmulatorExecutablePath)
if err != nil {
logger.Errorf("failed to run a kafka mock
cluster, %v", err)
- return nil, nil, err
+ return nil, err
}
mockClusters = append(mockClusters, kafkaMockCluster)
- datasetDTOs, err := toDatasetDTOs(datasets)
Review Comment:
i think we can check this before creating mock cluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
