Abacn commented on code in PR #25364:
URL: https://github.com/apache/beam/pull/25364#discussion_r1102080972
##########
sdks/java/io/google-cloud-platform/build.gradle:
##########
@@ -18,7 +18,13 @@
import groovy.json.JsonOutput
-plugins { id 'org.apache.beam.module' }
+plugins {
+ id 'org.apache.beam.module'
+ // For resolving Cloud Bigtable dependencies from custom registry that
includes Change Stream API.
+ id "maven-publish"
Review Comment:
maven-publish is handled in BeamModulePlugin and to my understanding should
not be added here.
move the below
```
repositories {
maven {
```
clause to
https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/Repositories.groovy
is the right approach
##########
sdks/java/io/google-cloud-platform/build.gradle:
##########
@@ -27,6 +33,22 @@ applyJavaNature(
],
)
+// For resolving Cloud Bigtable dependencies from custom registry that
includes Change Stream API.
+repositories {
+ maven {
+ url
"artifactregistry://us-central1-maven.pkg.dev/cloud-bigtable-ecosystem/bigtable-change-streams-preview"
+ }
+}
+configurations.all {
+ resolutionStrategy {
+ force group: 'com.google.cloud', name: 'google-cloud-bigtable', version:
'2.11.2-change-streams-preview1-SNAPSHOT'
Review Comment:
since these are all SNAPSHOT versions, they should not appear in beam
release versions. What is the time line that it will get released? If is within
a month or so, could you please create a GitHub issue and set milestone to
v2.46.0 as a release blocker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
