lostluck commented on PR #25249: URL: https://github.com/apache/beam/pull/25249#issuecomment-1425227682
Both of those are too extreme. A separate go.mod file wouldn't solve the issue anyway, since we would want to attach dependabot to it anyway. And in that case we'd want to have all the examples be treated the same, so it's not less work. Consistency is paramount to making things easy for others to engage with. I think we should either fix the single line that's changed, or ignore it. I've got enough on my plate to not worry about it for now, so I let you know incase you were more interested in making the small immediate change. Otherwise we just punt until the next update, which is sufficient awareness that we could make a fix when that happens. It costs us nothing to ignore it for a time (as it's not urgent), and we are not required to always make every update that the automated dependbot suggestions provide. The break doesn't invalidate the example. But it's also a small change that is easy to make. On Thu, Feb 9, 2023, 9:47 PM Damon ***@***.***> wrote: > @lostluck <https://github.com/lostluck> Do you think we should: > > 1. remove the entire sdks/go/examples/wasm example? > or > 2. create an experimental folder with its own go.mod, etc > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/25249#issuecomment-1425213293>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADKDOFIWT2THR3PN53WYMRLWWXI5PANCNFSM6AAAAAAUNHH2VM> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
