ziqi-ma commented on PR #24911: URL: https://github.com/apache/beam/pull/24911#issuecomment-1425266392
> @ziqi-ma Hi, is it ready for the final review? > > I confirm the tests are running for onnx. link: https://ci-beam.apache.org/job/beam_PreCommit_Python_Coverage_Commit/398/testReport/apache_beam.ml.inference.onnx_inference_test/ I am not a committer so passing this @jrmccluskey @damccorm @riteshghorse @tvalentyn > > Thanks again for the changes. > > Also, can you add this feature to the CHANGES.md defined at https://github.com/apache/beam/blob/master/CHANGES.md? > > Something like > > https://github.com/apache/beam/blob/64e40d2c018f8e906f4bec32ef67f02734a95721/CHANGES.md?plain=1#L57 > > I would like to get this before Feb 22nd so that it can be included in next release 2.46.0 Hi - I have fixed all comments. Think this is ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
