AnandInguva commented on code in PR #25393:
URL: https://github.com/apache/beam/pull/25393#discussion_r1103204387
##########
sdks/python/apache_beam/ml/inference/utils.py:
##########
@@ -94,7 +94,7 @@ class _GetLatestFileByTimeStamp(beam.DoFn):
started. If no such files are found, it returns a default file as fallback.
"""
TIME_STATE = CombiningValueStateSpec(
- 'count', combine_fn=partial(max, default=_START_TIME_STAMP))
+ 'max', combine_fn=partial(max, default=_START_TIME_STAMP))
Review Comment:
Lint is passing now. It is not related to this change.
##########
sdks/python/apache_beam/examples/inference/pytorch_image_classification_with_side_inputs.py:
##########
@@ -26,8 +26,11 @@
This pipeline follows the pattern from
https://beam.apache.org/documentation/patterns/side-inputs/
-This pipeline expects a PubSub topic as source, which emits an image
-path(UTF-8 encoded) that is accessible by the pipeline.
+To use the PubSub reading from a topic in the pipeline as source, you can
+publish a path to the model(resnet152 used in the pipeline from
+torchvision.models.resnet152) to the PubSub topic. Then pass that
+topic via command line arg --topic. The published path(str) should be
+UTF-8 encoded.
Review Comment:
Yes, corrected it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
