slilichenko commented on PR #25400: URL: https://github.com/apache/beam/pull/25400#issuecomment-1426377284
It is potentially of a concern, but in my opinion it's of a lesser problem. It's also related this bug <https://github.com/apache/beam/issues/21405> I opened a while ago. The need for "execution project" for BigQuery is only applicable to queries. It's possible that the tables referenced in the query are fully qualified with project ids, but the query is still required to be run in a different execution project to use a specific slot assignment. Sergei Lilichenko On Fri, Feb 10, 2023 at 1:24 PM Yi Hu ***@***.***> wrote: > ***@***.**** approved this pull request. > > Thanks. This looks good to me. > > This documentation is under BigQuery read. It leads to me to check the > codebase and I found currently there are some places we actually do not > respect bigQueryProject option in BigQuery write. e,g. in > DynamicDestination: > > > https://github.com/apache/beam/blob/cff82b5d2ea4efe9ae41f67609fd1737b76e3e2e/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinations.java#L128 > > here it sets the option at pipeline run time, and > DynamicDestination.getPipelineOptions is fetched in some other place, where > API calls will use default getProject() and do not consider > getBigQueryProject(). Is this something to concern? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/25400#pullrequestreview-1294035321>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABTVUN647IP4QSLUIZJ6I2TWW2WZFANCNFSM6AAAAAAUWZHU7E> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
