Abacn commented on code in PR #24274:
URL: https://github.com/apache/beam/pull/24274#discussion_r1105064269
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java:
##########
@@ -150,10 +150,14 @@ public class AvroUtils {
GenericData.get().addLogicalTypeConversion(new JodaTimestampConversion());
}
- // Unwrap an AVRO schema into the base type an whether it is nullable.
- static class TypeWithNullability {
- public final org.apache.avro.Schema type;
- public final boolean nullable;
+ /** Unwrap an AVRO schema into the base type an whether it is nullable. */
Review Comment:
then at lease we want to sync the content of AvroUtils in sdks/extension and
here in case the migration happens the the change gets dropped
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java:
##########
@@ -150,10 +150,14 @@ public class AvroUtils {
GenericData.get().addLogicalTypeConversion(new JodaTimestampConversion());
}
- // Unwrap an AVRO schema into the base type an whether it is nullable.
- static class TypeWithNullability {
- public final org.apache.avro.Schema type;
- public final boolean nullable;
+ /** Unwrap an AVRO schema into the base type an whether it is nullable. */
Review Comment:
then at least we want to sync the content of AvroUtils in sdks/extension and
here in case the migration happens the the change gets dropped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
