johnjcasey commented on code in PR #25472:
URL: https://github.com/apache/beam/pull/25472#discussion_r1106354913
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java:
##########
@@ -746,6 +755,12 @@ private static void fieldDescriptorFromTableField(
return ChronoUnit.MICROS.between(
Instant.EPOCH, Instant.ofEpochMilli(Long.parseLong((String)
value)));
} catch (NumberFormatException e2) {
+ if (((String) value).endsWith("UTC")) {
Review Comment:
we should not catch an exception to determine we should use an alternate
date time formatter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
