Abacn commented on code in PR #25240:
URL: https://github.com/apache/beam/pull/25240#discussion_r1107248911
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -110,26 +115,48 @@ public PTransform<PBegin, PCollection<Row>> buildReader()
{
return new PTransform<PBegin, PCollection<Row>>() {
@Override
public PCollection<Row> expand(PBegin input) {
- @Nullable String readQuery = config.getString("readQuery");
- if (readQuery == null) {
- readQuery = String.format("SELECT * FROM %s", location);
- }
-
- JdbcIO.ReadRows readRows =
- JdbcIO.readRows()
- .withDataSourceConfiguration(getDataSourceConfiguration())
- .withQuery(readQuery);
-
- @Nullable Short fetchSize = config.getInt16("fetchSize");
- if (fetchSize != null) {
- readRows = readRows.withFetchSize(fetchSize);
- }
- @Nullable Boolean outputParallelization =
config.getBoolean("outputParallelization");
- if (outputParallelization != null) {
- readRows =
readRows.withOutputParallelization(outputParallelization);
+ // If we define a partition column we need to go a different route
+ @Nullable String partitionColumn =
config.getString("partitionColumn");
Review Comment:
Hi @byronellis if you do not have time, I am willing to fix the comments in
order to make it in before Beam 2.46.0 cut.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
