kennknowles commented on issue #25485:
URL: https://github.com/apache/beam/issues/25485#issuecomment-1431955011
I spent a while to trace your logic, and it makes sense to me. I'm not sure
the best way to proceed. I hate tests with delays or inherent races in them,
but of course this one is specifically testing processing time and also
specifically avoiding dependency on TestStream.
Couple thoughts:
- if this is accurate, then will increasing the watermark delay make it
less flaky? and will a huge delay it should always pass.
- what we are trying to test is just that the second aggregation triggers
right away, it seems. There might be a different test that checks this, or a
more lenient verification condition.
Nice analysis!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
