Malarg commented on code in PR #25397:
URL: https://github.com/apache/beam/pull/25397#discussion_r1108375996
##########
playground/frontend/playground_components/assets/translations/en.yaml:
##########
@@ -17,12 +17,16 @@
errors:
error: 'Error'
+ failedParseOptions: "Failed to parse pipeline options, please check the
format (example: --key1 value1 --key2 value2), only alphanumeric and
\",*,/,-,:,;,',. symbols are allowed"
+ internetUnavailable: 'Internet connection is unavailable'
loading: 'Error while loading.'
loadingCatalog: 'Cannot load the example catalog.'
loadingExample: 'Cannot load the example.'
savingSnippet: 'Cannot create a shareable link.'
+ unknownError: 'Unknown error. Potential internet connection problem or CORS
issue'
Review Comment:
done
##########
playground/frontend/playground_components/lib/src/repositories/models/run_code_result.dart:
##########
@@ -33,13 +33,13 @@ enum RunCodeStatus {
}
const kFinishedStatuses = [
- RunCodeStatus.unknownError,
- RunCodeStatus.timeout,
RunCodeStatus.compileError,
+ RunCodeStatus.finished,
+ RunCodeStatus.preparationError,
RunCodeStatus.runError,
+ RunCodeStatus.timeout,
+ RunCodeStatus.unknownError,
RunCodeStatus.validationError,
- RunCodeStatus.preparationError,
- RunCodeStatus.finished,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
