TSultanov commented on code in PR #25508:
URL: https://github.com/apache/beam/pull/25508#discussion_r1108462580
##########
playground/backend/containers/java/Dockerfile:
##########
@@ -94,16 +94,7 @@ RUN cd /go/src/katas &&\
./gradlew jar &&\
mv util/build/libs/util.jar /opt/apache/beam/jars/util.jar
-# Install mitmpoxy
-RUN mkdir /opt/mitmproxy &&\
- cd /opt/mitmproxy &&\
- wget https://snapshots.mitmproxy.org/7.0.4/mitmproxy-7.0.4-linux.tar.gz &&\
- tar -zxvf mitmproxy-7.0.4-linux.tar.gz &&\
- mkdir /usr/local/share/ca-certificates/extra
-COPY allow_list_proxy.py /opt/mitmproxy/
-COPY allow_list.py /opt/mitmproxy/
-ENV HTTP_PROXY="http://127.0.0.1:8081";
-ENV HTTPS_PROXY="http://127.0.0.1:8081";
+RUN mkdir /usr/local/share/ca-certificates/extra
Review Comment:
Please remove
##########
playground/backend/containers/scio/Dockerfile:
##########
@@ -55,17 +56,7 @@ echo "deb https://repo.scala-sbt.org/scalasbt/debian /" |
tee /etc/apt/sources.l
curl -sL
"https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2EE0EA64E40A89B84B2DF73499E82A75642AC823";
| apt-key add
RUN apt-get update && apt-get install -y sbt
-
-## Install mitmpoxy
-RUN mkdir /opt/mitmproxy &&\
- cd /opt/mitmproxy &&\
- wget https://snapshots.mitmproxy.org/7.0.4/mitmproxy-7.0.4-linux.tar.gz &&\
- tar -zxvf mitmproxy-7.0.4-linux.tar.gz &&\
- mkdir /usr/local/share/ca-certificates/extra
-COPY allow_list_proxy.py /opt/mitmproxy/
-COPY allow_list.py /opt/mitmproxy/
-ENV HTTP_PROXY="http://127.0.0.1:8081";
-ENV HTTPS_PROXY="http://127.0.0.1:8081";
+RUN mkdir /usr/local/share/ca-certificates/extra
Review Comment:
Please remove
##########
playground/backend/containers/mitmproxy/settings.gradle:
##########
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+rootProject.name = 'apache-beam-playground-backend-mitmproxy'
Review Comment:
Please add empty line to the end of file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
