igorbernstein2 commented on code in PR #24015:
URL: https://github.com/apache/beam/pull/24015#discussion_r1093417205
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableConfig.java:
##########
@@ -115,6 +120,11 @@ BigtableConfig withTableId(ValueProvider<String> tableId) {
return toBuilder().setTableId(tableId).build();
}
+ BigtableConfig withAppProfileId(@Nullable ValueProvider<String>
appProfileId) {
Review Comment:
If you have a non-null check, then this cant be Nullable
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableClientWrapper.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.bigtable;
+
+import static org.apache.beam.sdk.io.gcp.bigtable.RowUtils.byteString;
+import static org.apache.beam.sdk.io.gcp.bigtable.RowUtils.byteStringUtf8;
+
+import com.google.auth.Credentials;
+import com.google.cloud.bigtable.admin.v2.BigtableTableAdminClient;
+import com.google.cloud.bigtable.admin.v2.models.CreateTableRequest;
+import com.google.cloud.bigtable.config.BigtableOptions;
+import com.google.cloud.bigtable.config.CredentialOptions;
+import com.google.cloud.bigtable.data.v2.BigtableDataClient;
+import com.google.cloud.bigtable.data.v2.models.RowMutation;
+import java.io.IOException;
+import java.io.Serializable;
+import org.apache.beam.sdk.annotations.Internal;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+@Internal
+public class BigtableClientWrapper implements Serializable {
+ private final BigtableTableAdminClient tableAdminClient;
+ private final BigtableDataClient dataClient;
+
+ private final BigtableOptions bigtableOptions;
+
+ public BigtableClientWrapper(
+ String project,
+ String instanceId,
+ @Nullable Integer emulatorPort,
+ @Nullable Credentials gcpCredentials)
+ throws IOException {
+ BigtableOptions.Builder optionsBuilder =
+ BigtableOptions.builder()
+ .setProjectId(project)
+ .setInstanceId(instanceId)
+ .setUserAgent("apache-beam-test");
+ if (emulatorPort != null) {
+ optionsBuilder.enableEmulator("localhost", emulatorPort);
+ }
+ if (gcpCredentials != null) {
+
optionsBuilder.setCredentialOptions(CredentialOptions.credential(gcpCredentials));
+ }
+ bigtableOptions = optionsBuilder.build();
+
+ BigtableHBaseVeneeringSettings settings =
+ BigtableHBaseVeneeringSettings.create(bigtableOptions);
Review Comment:
Why do you need all of this? Can't you use the idiomatic settings directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
