davidcavazos commented on pull request #12277: URL: https://github.com/apache/beam/pull/12277#issuecomment-659692458
> * The correct staging link seems to be (http://apache-beam-website-pull-requests.storage.googleapis.com/12277/documentation/transforms/python/aggregation/combineperkey/index.html). I reviewed that it LGTM. Thanks, forgot to update that part. > * Please revert the changes to other files. It makes the history much more cleaner and focused. Will do > * A question to both you and @rosetn - There is a quite a bit of content duplication between this page and CombineGlobally page. Is there a more de-duplicated way of presenting this content? They are different transforms and so they both have their own code snippets, we could try to merge both into a single page but that might be a little too long since it would have 2 code snippets for each example. @rosetn any thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
