lostluck commented on PR #25565: URL: https://github.com/apache/beam/pull/25565#issuecomment-1437398474
R: @johannaojeling cc: @jrmccluskey This is a big PR, but it is fairly well unit tested at least. This is largely how anything for the runner actually gets done. Organization wise, stageState should remain below the ElementManager because aside from tracking a given stage's stage, most of it's methods are around the actual bundle readiness for the stage, which I think is easier to understand after reading the element manager handling. What do you think? I think this might be the 2nd last PR too. The next one requires element manager in, and I don't think the remainder is meaningfully separable. If anything it's only very large because of the test suites that validate everything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
