scwhittle commented on PR #25186: URL: https://github.com/apache/beam/pull/25186#issuecomment-1438399226
I changed to a background thread that consumes the queue until the stream breaks or the client is closed. It restores the previous loggers and flushes remaining logs to them if unclean closed. It doesn't try to reconnect the logging stream, it surfaces the error of the logging client the same spot we check the control client is not completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
