cushon commented on code in PR #23210:
URL: https://github.com/apache/beam/pull/23210#discussion_r1113465324
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoderGenerator.java:
##########
@@ -169,7 +169,7 @@ public static Coder<Row> generate(Schema schema) {
rowCoder =
builder
.make()
- .load(Coder.class.getClassLoader(),
ClassLoadingStrategy.Default.INJECTION)
+ .load(Coder.class.getClassLoader(),
getClassLoadingStrategy(Coder.class))
Review Comment:
The change here from `Coder.class.getClassLoader()` to
`ReflectHelpers.findClassLoader(schema.getClass().getClassLoader())` is causing
some of the failures from https://github.com/apache/beam/pull/25566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
