ibzib commented on a change in pull request #12259:
URL: https://github.com/apache/beam/pull/12259#discussion_r456160558
##########
File path: sdks/python/apache_beam/dataframe/doctests_test.py
##########
@@ -63,6 +63,20 @@
ignored result
'''
+ERROR_RAISING_NAME_ERROR_TESTS = '''
+>>> import apache_beam
+>>> raise apache_beam.dataframe.frame_base.WontImplementError('anything')
+ignored exception
+>>> raise NameError
+ignored exception
+>>> undefined_name
+ignored exception
+>>> 2 + 2
Review comment:
That sounds fine. If we encounter an issue like this example simulates,
I assume we can always manually add the test to the skip map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
